Dealing with createMsgChannel errors #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
film42
force-pushed
the
gt/whats_up_with_chans
branch
from
2bcf33c
to
b79b115
Compare
|
Rebased and ready for 👀 . |
abrandoned
reviewed
Nov 7, 2017
lib/protobuf/nats/jnats.rb
Outdated
| # Do not depend on #close for a greaceful disconnect. | ||
| def connection | ||
| return @connection unless @connection.nil? | ||
| connect(options || {}) |
There was a problem hiding this comment.
should this path call close? (or at the top of connect?)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking a stab at #32 but can't be sure if this fixes it just yet.
Here's what I'm trying:
start_client_nats_connectionavoid setting the memo until the client connection has completed.@start_client_nats_connection && @client_nats_connectionwhen memo-ing the client nats connection setup. I'm not sure this is actually addressing anything because in the examples we were clearly inside an instance ofJNatsbut only the inner@connectionwasnil.#connectshould we ever find the@connectionnil. I'm not sure this is the best idea, but if we get "no servers found" errors we'll know there's a race condition in the setup code. I added a test here but I'm not sure we'll want to keep this behavior forever.NOTE: This is pointed at @abrandoned 's pre-released branch right now.
cc @abrandoned @quixoten